feat(font): add commit-mono #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayuhito
requested changes
Jul 31, 2024
There was a problem hiding this comment.
Apologies for the delay. I was on holiday. 🎉
Everything looks good to me, except for the weights that are split at intervals of 25. This can be problematic if this font is ever uploaded to Google Fonts, as they will produce static variants with weight intervals of 100. In the long run, that could lead to a breaking change in a patch release due to how our system is set up (which automatically transitions to Google Fonts when available).
Could you remove the extra weights and only keep them in intervals of 100?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Commit Mono v1.143 / v143.
Notes
Font files downloaded with default "customizations" from https://commitmono.com/ >
07 Customizethen converted fromotftowoffandwoff2.metadata.jsonlicense url is set to the GitHub tag link (https://github.com/eigilnikolajsen/commit-mono/blob/v1.143/src/txt/license.txt), not commit (https://github.com/eigilnikolajsen/commit-mono/blob/a042aaa2a43da91544b1d02ee12819cb698db7d2/src/txt/license.txt). Should this be changed?
I've also selected to use the GitHub tag version of the font (v1.143) rather than the site version (v143). Not sure which one is preferable here.
Settings
"Customization" JSON:
{"weight":400,"italic":false,"alternates":{"cv01":false,"cv02":false,"cv03":false,"cv04":false,"cv05":false,"cv06":false,"cv07":false,"cv08":false,"cv09":false,"cv10":false,"cv11":false},"features":{"ss01":false,"ss02":false,"ss03":true,"ss04":true,"ss05":true},"letterSpacing":0,"lineHeight":1}Conversion
Downloaded fonts are
otffiles. The following tools were used for conversion.otftowoff:sfnt2woff-zopflidownloaded viabramstein/webfonttoolstap (v1.1.0)otftowoff2:woff2via brew (v1.0.2)Both using default settings.
Variable Font
Commit Mono is a variable font. I couldn't find any guidance on providing variable font files for non Google Font fonts. I'd like to be able to contribute those as well since they support OpenType features.Edit: Just saw fontsource/fontsource#728.